Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action): github action to apply release label is broken #11794

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Oct 15, 2024

Description

This fixes Github action that was broken on Sep 27th with this PR: #10917

A tentative fix was made on Oct 10th with this PR, but it didn't succeed: #11745

Related issues

Fixes https://github.com/MetaMask/MetaMask-planning/issues/3493

Here's also the corresponding Slack thread

Manual testing steps

Before this PR is merged:

  1. Clone the repo
  2. Run the following CLI commands
cd .github/scripts
node -p "require('../../package.json').version"
  1. Check that the release version printed corresponds to the one indicated in main package.json

Once this PR will be merged:

  1. Go to metamask-mobile repo's Github action
  2. Check that Add release label to PR and linked issues when PR gets merged executions are back to green

Screenshots/Recordings

  • None

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 15, 2024
@NicolasMassart
Copy link
Contributor

The second step of the manual test does not show any green action run

Copy link

sonarcloud bot commented Oct 15, 2024

@gauthierpetetin
Copy link
Contributor Author

Yes, you're right, we'll only have green action run once this PR will be merged.
I've updated "manual testing steps" section to indicate testing steps that can be executed before this PR gets merged.

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
image

@gauthierpetetin gauthierpetetin added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit fc55bce Oct 15, 2024
61 checks passed
@gauthierpetetin gauthierpetetin deleted the fix/github-action-release-label branch October 15, 2024 12:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants